refactor: opentelemetry-instrumentation-urllib #3639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A lot of code imports semantic conventions attributes from opentelemetry.semconv.trace.SpanAttributes instead of the preferred opentelemetry.semconv.attributes and opentelemetry.semconv.incubating.
This PR refactors the semantic conventions to use the new stable attribute modules instead of the deprecated SpanAttributes class.
Updates to instrumentation code:
SpanAttributes.HTTP_URL
withHTTP_URL
inresponse_hook
and_instrumented_open_call
methods for semantic convention compliance. [1] [2]Updates to test cases:
test_urllib_integration.py
to use the new constants (HTTP_METHOD
,HTTP_URL
,HTTP_STATUS_CODE
) instead ofSpanAttributes
. This change affects multiple test methods, includingtest_basic
,test_not_foundbasic
, and others. [1] [2] [3] [4] [5] [6] [7]Refs: #3475
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.